slachiewicz commented on issue #497:
URL: 
https://github.com/apache/maven-install-plugin/issues/497#issuecomment-7064026538

   Closing this as complete. The last PR is #500, now merged; the two migration 
PRs #498 (master) and #499 (4.x) are also merged.
   
   ## What changed
   
   Twenty integration tests were replaced by JUnit 5 unit tests with their 
assertions preserved, and every remaining JIRA-keyed IT directory was renamed 
to describe what it tests. The shared IT names and the new case names are now 
identical on both lines; `maven-install-plugin-4.x` remains Maven 4 only. The 
final sync backported the shared `InstallTestHelper`. No production code 
changed.
   
   ## CI, before and after
   
   Approximate job-minutes from single successful `push` runs of the Verify 
workflow (runner speed varies, and the matrix was trimmed from 17 to 12 jobs on 
master and 8 to 6 on 4.x in early November, so only same-matrix runs are 
compared):
   
   | branch | before | after | change |
   |---|---:|---:|---:|
   | master (12 jobs) | 28 min (12:17) | 21 min (13:27) | ~−25% |
   | 4.x (6 jobs) | 13 min (12:43) | 11 min (13:40) | ~−15% |
   
   These are single runs, not a statistically meaningful speedup; the main gain 
is deterministic failures and a clearer test/IT split, which was the goal.
   
   ## Lessons
   
   - The 4.x harness mocks `ArtifactInstaller`, so `maven-metadata-local.xml` 
file assertions are expressed as install-request assertions there; forcing them 
to match the 3.x file-based checks would have weakened one branch.
   - Review on #499 caught duplicated helper code and an over-broad catch; both 
were fixed before merge.
   - CI baselines taken from PR Check runs were useless; only push runs of the 
Verify workflow with the same matrix are comparable.
   
   Further test-debt work (triage of the remaining ITs, `verify.groovy` 
assertion cleanup, contributor documentation) is separate from this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to