slachiewicz commented on issue #501: URL: https://github.com/apache/maven-install-plugin/issues/501#issuecomment-7064777841
Closing as complete. The last PR is #505, now merged; #502/#504 on master and #503 on 4.x are also merged. Across the two tranches, 27 ITs were replaced by JUnit 5 unit tests on each line and every remaining JIRA-keyed IT directory was renamed to describe what it tests. Test names and IT names are aligned across master and `maven-install-plugin-4.x`; the 4.x branch stays Maven 4 only. ## CI, approximate job-minutes from single successful push runs of Verify | branch | before this work | after tranche 1 | after tranche 2 | |---|---:|---:|---:| | master (12 jobs) | 28 min | 21 min | 17 min | | 4.x (6 jobs) | 13–15 min | 11 min | 10 min | Single runs, so treat as indicative rather than a measured speedup. The matrix was trimmed before this work, and only same-matrix runs are compared. ## What remains About ten ITs per line, all of which need real Maven behaviour: reactor/deferred install, `-T2` parallel, `-f` alternate POM, embedded-POM execution and the setup support project. Those are intentionally left as ITs. Known harness difference, documented in the tests: the 4.x `@MojoTest` harness mocks `ArtifactInstaller`, so metadata existence is asserted via coordinate-derived paths rather than physical files. No assertions were dropped. Follow-up work is separate: converting surviving `verify.groovy` scripts from `throw`/`return true` to `assert`, and documenting the IT/unit split for contributors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
