slachiewicz opened a new pull request, #751:
URL: https://github.com/apache/maven-doxia-sitetools/pull/751

   Drop the direct dependency on `plexus-utils`. The XML classes the generated 
Modello readers/writers need already come from `plexus-xml` (same package 
names), so only the non-XML utility usages had to be replaced.
   
   ### Changes
   
   - `doxia-site-model`, `doxia-site-renderer`, `doxia-integration-tools`: 
remove the direct `plexus-utils` dependency.
   - `IOUtil` → commons-io `IOUtils` and JDK NIO; plexus `StringUtils` → 
commons-lang3 (renderer, already a dependency) or JDK `String` (other modules, 
to avoid an unpinned new dependency); `Os.isFamily` → 
`SystemUtils.IS_OS_WINDOWS`; `ReflectionUtils` → `FieldUtils` in tests.
   - Add `org.apache.maven.doxia.site.PathTool`, a trimmed copy of the six 
public methods used from `org.codehaus.plexus.util.PathTool`. It is needed as a 
Velocity context tool in the renderer, so the class is instantiable. Parity was 
checked against plexus-utils over 2,704 input combinations with zero 
mismatches, and `PathToolTest` pins the documented behaviour.
   - Replace `DirectoryScanner` / `FileUtils.getFileNames` with a local 
Ant-pattern scanner that preserves the caller's excludes and the scanner's 
default excludes. Parity checked against plexus-utils for all tested 
include/exclude combinations.
   - Use commons-lang3 `StringUtils.endsWithIgnoreCase` instead of the local 
copy, removing the stale TODO.
   
   ### Verification
   
   - `mvn -o test`: 120 tests pass across all six modules (previously 114; six 
new `PathToolTest` cases).
   - Checkstyle: 0 violations; Spotless applied (JDK 21).
   - `dependency:analyze`: no new used-undeclared or unused-declared 
dependencies.
   
   ### Note
   
   `plexus-utils` remains on the classpath transitively through 
`org.eclipse.sisu.plexus`, `plexus-velocity`, `plexus-interpolation`, 
`plexus-testing` and the Maven SCM providers. This change removes the direct 
declarations and every source usage; removing it from the graph entirely would 
require exclusions across those components and is out of scope here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to