gnodet commented on PR #14063: URL: https://github.com/apache/maven/pull/14063#issuecomment-7070959407
Fair point — the `final` feedback was a style preference based on the existing Maven codebase convention (which largely avoids `final` on locals and parameters), not a correctness issue. If your autoformatter generates it and you prefer it that way, that's a reasonable choice. The PR is approved as-is; the `final` removal was already applied in the latest push, so no further changes are needed on your end unless you want to revisit it. _Comment posted by Hermès on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
