arturobernalg opened a new pull request, #1454:
URL: https://github.com/apache/maven-javadoc-plugin/pull/1454
Fixes #915. Fixes #1173 (same root cause, reported again later).
getClassNamesFromJar() includes module-info.class in the list of class names
it returns from a jar, so getTagletClassNames() tries to load it like any other
class. ClassLoader.loadClass("module-info") always throws NoClassDefFoundError
(ACC_MODULE is set), which aborts taglet auto-detection for the whole jar
whenever a tagletArtifact happens to be a Java 9+ module, even though its real
taglet classes are fine.
The fix skips the module-info entry before adding it to the class list.
Added a test that builds a jar with only a module-info.class entry and asserts
getTagletClassNames() returns an empty list instead of throwing.
To make clear that you license your contribution under the Apache License
Version 2.0, January 2004 (https://www.apache.org/licenses/LICENSE-2.0) check
one of the following:
- [x] I hereby declare this contribution to be licensed under the Apache
License Version 2.0, January 2004
- [x] I hereby declare that I have filed an Apache Individual Contributor
License Agreement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]