[
http://jira.codehaus.org/browse/MRRESOURCES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127507
]
Daniel Kulp commented on MRRESOURCES-30:
----------------------------------------
I disagree with this. When implementing the sorting stuff, I did run
originally just use the organization name for sorting, but due to a bunch of
bad poms, the results were not correct and not reproduceable.
For example, we depend on a BUNCH of stuff at Apache. However, the poms put
different organization URL's in there all over the place. (The jakarta folks
are really bad) The resulting NOTICE would pretty much pick different values
for the ${organization.url} parameter depending on the JDK, OS, etc... And
most of the time, it wasn't correct.
SOMETIMES, we would get the (almost) correct:
Apache Software Foundation (http://www.apache.org/)
but many times we would get:
The Apache Software Foundation (http://jakarta.apache.org)
or other variations that are just wrong. Thus, I decided to keep the URL as
part of the sort so that the projects that DO put the correct information in
their poms (or inherit from the appropriate apache parent) aren't screwed up by
the projects that don't do the right things.
> When comparing organizations, don't compare the url
> ---------------------------------------------------
>
> Key: MRRESOURCES-30
> URL: http://jira.codehaus.org/browse/MRRESOURCES-30
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Bug
> Affects Versions: 1.0-alpha-6, 1.0-beta-2
> Reporter: Dennis Lundberg
> Attachments: NOTICE
>
>
> The OrganizationComparator in ProcessRemoteResourcesMojo takes into account
> both the organization's name *and* url. This leads to strange generated
> NOTICE files, like the one attached, which comes from a slightly modified
> trunk of commons-validator. I feel that the comparator should be changed so
> that it only compares the name of the organization. An alternative way would
> be to have two configurable comparators to choose from. I'm willing to do the
> coding, but want to solicit other's opinions first.
> Also see discussions here:
> https://issues.apache.org/jira/browse/COMMONSSITE-21
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
