[
http://jira.codehaus.org/browse/SCM-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=161301#action_161301
]
Brian Atkinson edited comment on SCM-431 at 1/16/09 9:13 PM:
-------------------------------------------------------------
I have attached a patch that I believe should fix this bug. I have also
included tests to cover this case.
The change was a simple one line change. Adding HTTP to the list of protocols
that "needsAuthentication()" or in reality gets parsed for authentication
information in the URL.
EDIT: I forgot to mention the patch is against trunk.
was (Author: nairb774):
I have attached a patch that I believe should fix this bug. I have also
included tests to cover this case.
The change was a simple one line change. Adding HTTP to the list of protocols
that "needsAuthentication()" or in reality gets parsed for authentication
information in the URL.
> Username and Password cause NumberFormatException in scm:hg:http URLS
> ---------------------------------------------------------------------
>
> Key: SCM-431
> URL: http://jira.codehaus.org/browse/SCM-431
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-mercurial (hg)
> Environment: Hg version: 1.1+20081202
> MacOSX 10.5.4
> Java version "1.6.0_07"
> Maven version: 2.0.6
> Reporter: Andrew Denyes
> Attachments: SCM-431.patch, stack_parse_x.txt
>
>
> This only affects Mercurial repository URLS using http protocol.
> We are using the hgwebdir CGI along with HTTP basic auth. SCM operations
> during release:prepare fail because http auth is not provided to the cgi
> frontend to the repo. Adding the auth credentials to the URL results in
> NumberFormatException.
> The following scm element results in number parse exception, because the
> colon is parsed during host and port parsing, instead of user/pass parsing.
> <scm>
>
> <connection>scm:hg:http://adenyes:[email protected]/code/ebi</connection>
>
> <developerConnection>scm:hg:http://adenyes:[email protected]/code/ebi</developerConnection>
> </scm>
> Suggested fix: return needsAuthentication true for HTTP URLs that contain an
> @ symbol,
> or
> always parse for user/pass and always include in URI if they are set.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
