[ 
http://jira.codehaus.org/browse/MSITE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=165254#action_165254
 ] 

Per Lindfors commented on MSITE-129:
------------------------------------

I have done some quick testing of 2.0-SNAPSHOT from people.apache.org, and this 
is what I've found so far:

I have the following project structure:

{noformat}
+- myproj/ (parent -> super-pom-A)
     +- module-1 (parent -> super-pom-B)
     +- module-2 (parent -> super-pom-C)
     +- module-3 (parent -> super-pom-D)
     +- src/
          +- site/
               +- site.xml
{noformat}

The directory layout for my deployment site is still not correct/different from 
the layout created when you have aggregation and inheritence between the 
"top/current" project and the modules. This is what I get:

{noformat}
+- super-pom-A
     +- myproj
+- super-pom-B
     +- module-1
+- super-pom-C
     +- module-2
+- super-pom-D
     +- module-3
{noformat}

This is what it should look like:

{noformat}
+- myproj
     +- module-1
     +- module-2
     +- module-3
     +- css/
     +- images/
     +- index.html
     +- ...

{noformat}


*Result*
- The module links are created but broken (in beta-7 the links weren't even 
created - I think). 
- Incorrect structure of site
- the site.xml is not propagated to modules, only to myproj(I don't have 
site.xml in modules so maybe this isn't a bug/issue?)


> modules list empty if modules don't use this project as parent in reactor 
> build
> -------------------------------------------------------------------------------
>
>                 Key: MSITE-129
>                 URL: http://jira.codehaus.org/browse/MSITE-129
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>          Components: multi module
>    Affects Versions: 2.0-beta-5
>            Reporter: Kenney Westerhof
>            Assignee: Dennis Lundberg
>            Priority: Minor
>             Fix For: 2.0
>
>
> The code in the AbstractSiteRenderingMojo does the following:
> - if it's running in a reactor build (i.e. more than 1 project in the reactor 
> projects) it scans all
> projects to see if it's parent project equals the current project. If so, 
> it's marked as a module.
> - if it's running on a single project, the project.build.modules is consulted 
> and those modules
> are marked as modules.
> I've got a 'fake' root pom, for utility purposes: it lists all projects as 
> modules so that I can easily
> built everything and generate a site. However, this fake root pom is never 
> used as a parent - there's
> a /pom/pom.xml project for that.
> The result of this is that the modules list is empty.
> A workaround is to first run 'mvn site' and then 'mvn site -N'.
> I'm not sure what the correct solution should be - basically now 2 site 
> layouts are implemented:
> - a physical layout where the modules match the <modules> section of the pom, 
> reflecting filesystem layout,
> - a project hierarchy layout based on <parent>
> and one or the other is used depending on wheter the build contains more than 
> 1 project or not.
> My first feeling is that since the tag is called ${modules} (or <menu 
> ref="modules"/>) that
> the site should use the <modules>, not the <parent>. 
> It should also take into consideration, that IF a reactor build is running, 
> it should only use the modules that are also
> in the reactor (so you can use -r -Dmaven.reactor.excludes=.. to generate a 
> site with not all projects in it).
> Thoughts?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to