[ 
http://jira.codehaus.org/browse/MASSEMBLY-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180613#action_180613
 ] 

Dave Hallam commented on MASSEMBLY-412:
---------------------------------------

Hi Scott,

Came across this posting as I've just had the same issue, except that it was 
corrupting a java class file and a zip file.  

But I have figured out what the problem was.  In the distribution.xml file, I 
had the following:

{noformat}
        <fileSet>
            <directory>config</directory>
            <lineEnding>unix</lineEnding>
            <fileMode>0744</fileMode>
            <includes>
                <include>**</include>
            </includes>
            <outputDirectory>/myapp/config</outputDirectory>
        </fileSet>
{noformat}

The problem is that the lineEnding feature appears to scan binary files for an 
EOL sequence of bytes and replaces them.  So if that sequence appears in your 
binary file, it corrupts it.

The solution is to either remove the lineEnding configuration or to split the 
fileset into two - one that deals with text files and the other that deals with 
binary.

Hope that sorts you out.

Regards,

Dave

> Assembly corrupts images when placing them in ZIP file
> ------------------------------------------------------
>
>                 Key: MASSEMBLY-412
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-412
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-3
>            Reporter: Scott Battaglia
>         Attachments: bad_ja-sig-logo.gif, ja-sig-logo.gif
>
>
> I've noticed this with previous versions of the plugin (i.e. Beta 1), but I'm 
> still seeing it with Beta 3.  When I build my assembly, some of the images in 
> the webapp module are being corrupted.  I'll attach the image (note, that in 
> the included .WAR file the images are fine).  The bad one is prefixed with 
> bad.
> You can try this yourself.  Our code is publicly available at:
> https://www.ja-sig.org/svn/cas3/trunk
> Thanks
> Scott

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to