[
http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=184895#action_184895
]
Olivier Lamy edited comment on MWAR-164 at 7/26/09 3:11 AM:
------------------------------------------------------------
So we need to detect *.xml files (in a harcoded way ?).
This need some changes in DefaultMavenFileFilter#copyFile.
Something like
pseudo code without any formating :P
{code}
if ( file.endWith (*.xml) )
encoding = ReaderFactory.newXmlReader( from ).getEncoding();
{code}
BTW this new way of filtering should be off by default (and configurable).
As this can break some builds.
WDYT ?
was (Author: olamy):
So we need to detect *.xml files (in a harcoded way ?).
This need some changes in DefaultMavenFileFilter#copyFile.
Something like
pseudo code without any formating :P
{code}
if ( file.endWith (*.xml) )
encoding = ReaderFactory.newXmlReader( from ).getEncoding();
{code}
WDYT ?
> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
> Key: MWAR-164
> URL: http://jira.codehaus.org/browse/MWAR-164
> Project: Maven 2.x WAR Plugin
> Issue Type: Improvement
> Affects Versions: 2.1-alpha-1
> Reporter: kai lilleby
> Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
