[
http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196470#action_196470
]
Arnaud Heritier commented on MECLIPSE-514:
------------------------------------------
Really serious !!! When I'm talking about testcase it's not a unit test but an
integration test that shows what you have in your pom and what you expect in
your generated eclipse configuration files.
Why ? because this plugin is the more complex of our plugins with the larger
base code to try to handle all versions of eclipse, its proprietary versions,
its extensions and more.
This plugin is quite dead because of not having created enough tests and each
change today is more and more dangerous.
Latests versions had many important regressions because that.
Thus excuse me to try to ask to have test case to validate our developments but
this for me the only solution to improve things.
In the case of this issue I agree that your description should allow us to
create a such integration testcase and your fix seems to be good. But when
someone who didn't delivered the patch comes to just say "hey !! what are you
doing you just have to fix...." I'm not agree. No we don't just have to ... We
have to spend some time on it to do all of that.
Cheers,
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java
> 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java, JeeUtils.patch
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always
> contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute
> "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding
> file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
