[
http://jira.codehaus.org/browse/MRELEASE-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=232961#action_232961
]
Michael Glauche edited comment on MRELEASE-261 at 8/24/10 10:10 AM:
--------------------------------------------------------------------
After some digging i think the patch for flat modules is broken for cvs. It
seems the recent patch to tag SVN correctly did stop CVS from tagging it. If i
look into ScmTagPhase the ScmRepository gets initialized with:
{code}
repository =
scmRepositoryConfigurator.getConfiguredRepository(
basedirAlignedReleaseDescriptor.getScmSourceUrl(),
releaseDescriptor,
releaseEnvironment.getSettings() );
{code}
But basedirAlignedReleaseDescriptor.getScmSourceUrl() yields
"...cvsserver|/home/cvs/repository", note the missing project AND the missing
module ...
If i change it to the same code the SvnCommitPhase is using things are starting
to look better, when i change the ScmFileSetConstructor back to
releaseDescriptor.getWorkingDirectory() the tags are written to the main
project at least. (But this of course breaks the SVN tagging ...)
@Eric,
thanks for the links, nice explanation of the problem, but i'm stuck with
cvs, you only present some solution for svn, or did i miss something ?
was (Author: mglauche):
After some digging i think the patch for flat modules is broken for cvs. It
seems the recent patch to tag SVN correctly did stop CVS from tagging it. If i
look into ScmTagPhase the ScmRepository gets initialized with:
{code}
repository =
scmRepositoryConfigurator.getConfiguredRepository(
basedirAlignedReleaseDescriptor.getScmSourceUrl(),
releaseDescriptor,
releaseEnvironment.getSettings() );
{code}
But basedirAlignedReleaseDescriptor.getScmSourceUrl() yields
"...cvsserver|/home/cvs/repository", note the missing project AND the missing
module ...
If i change it to the same code the SvnCommitPhase is using things are starting
to look better, when i change the ScmFileSetConstructor back to
releaseDescriptor.getWorkingDirectory() the tags are written to the main
project at least. (But this of course breaks the SVN tagging ...)
@Eris,
thanks for the links, nice explanation of the problem, but i'm stuck with
cvs, you only present some solution for svn, or did i miss something ?
> release:prepare should support flat directory multi-module projects
> -------------------------------------------------------------------
>
> Key: MRELEASE-261
> URL: http://jira.codehaus.org/browse/MRELEASE-261
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Components: prepare
> Environment: linux / maven2 / svn
> Reporter: paul.whe...@gmail.com
> Assignee: Maria Odea Ching
> Fix For: 2.0
>
> Attachments: flatProject.main.patch, flatProject.test.patch,
> maven-release-issue.tar.gz, maven-release-issue.zip,
> MRELEASE-261-sample-project.zip, MRELEASE-261-with-its-v3.patch,
> MRELEASE-261-with-its.patch, MRELEASE-261.patch, odd-tags.png,
> PrepareReleaseMojo.patch
>
>
> What I mean by flat file structure firstly.
> parent/pom.xml
> module1/pom.xml
> module2/pom.xml
> .
> .
> .
> module15/pom.xml
> the parent references the modules like so
> <modules>
> <module>../module1</module>
> <module>../module2</module>
> .
> .
> .
> <module>../module15</module>
> </modules>
> When i release:prepare only the parent project is tagged the modules
> projects versions are incremented etc but the modules are not tagged in svn.
> I use this structure as i use eclipse as my IDE.
> I would love to see a fix for the issue marked as closed here
> http://jira.codehaus.org/browse/MRELEASE-138. I am currenrly tagging by hand
> each submodule of the projects but it would be so nice to have the release
> plugin do this for me.
> forgive my english.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
