[ 
http://jira.codehaus.org/browse/MDEP-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=254693#action_254693
 ] 

Robert Scholte commented on MDEP-300:
-------------------------------------

If there's no specific {{UnArchiver}} mapping for {{test-jar}} or {{bundle}} 
the patch would indeed break the unpacking of those types. Introducing 
something like {{archiveType}} looks a bit redundant to me. The cleanest way 
would be to complete the {{components.xml}} with all the well-known types, the 
safest way would be to first check for an {{UnArchiver}} by type, next for an 
{{UnArchiver}} by extension.

> Unpacking artifacts should be based on type, not on extension
> -------------------------------------------------------------
>
>                 Key: MDEP-300
>                 URL: http://jira.codehaus.org/browse/MDEP-300
>             Project: Maven 2.x Dependency Plugin
>          Issue Type: Bug
>          Components: unpack, unpack-dependencies
>    Affects Versions: 2.1
>            Reporter: Robert Scholte
>            Assignee: Brian Fox
>            Priority: Critical
>         Attachments: typebased-unpack.patch
>
>
> I've defined a custom lifecycle with a new packaging type "custom-ear". This 
> type is generated by calling some external tool, which generates a (non java) 
> ear-file. During the {{pre-integration-test}} I need to unpack it. Since 
> {{dependency:unpack}} and {{dependecy:unpack-dependencies}} is based on the 
> extension I'm not able to specify my own unArchiver. 
> Attached a patch which should fix this problem.
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to