ciManagement configuration ignore combine.children
--------------------------------------------------

                 Key: MNG-5052
                 URL: http://jira.codehaus.org/browse/MNG-5052
             Project: Maven 2 & 3
          Issue Type: Bug
          Components: POM
    Affects Versions: 3.0.3, 2.2.1
            Reporter: Philippe Busque


The configuration ciManagement/notifiers ignore the attribute 
combine.children="append" when merging with a parent POM.

When merging, no matter what, the child pom overwrite the parent notifiers, 
even if combine.children="append" is supplied.


Parent POM fragment

  <ciManagement>
    <system>continuum</system>
    <url>http://continuum.com</url>
    <notifiers>
      <notifier>
        <type>mail</type>
        <sendOnError>true</sendOnError>
        <sendOnFailure>true</sendOnFailure>
        <sendOnSuccess>true</sendOnSuccess>
        <sendOnWarning>true</sendOnWarning>
        <configuration>
          <address>[email protected]</address>
        </configuration>
      </notifier>
    </notifiers>
  </ciManagement>


========================================================

Child POM fragment

   <ciManagement>
    <notifiers combine.children="append">
      <notifier>
        <type>mail</type>
        <sendOnError>false</sendOnError>
        <sendOnFailure>true</sendOnFailure>
        <sendOnSuccess>false</sendOnSuccess>
        <sendOnWarning>false</sendOnWarning>
        <configuration>
          <address>[email protected]</address>
          <committers>true</committers>
        </configuration>
      </notifier>
    </notifiers>
  </ciManagement>


=========================================================

Resulted POM fragment ( using mvn projecthelp:effective-pom )

  <ciManagement>
    <notifiers>
      <notifier>
        <sendOnError>false</sendOnError>
        <sendOnSuccess>false</sendOnSuccess>
        <sendOnWarning>false</sendOnWarning>
        <configuration>
          <address>[email protected]</address>
          <committers>true</committers>
        </configuration>
      </notifier>
    </notifiers>
  </ciManagement>



=========================================================
Expected POM fragment

  <ciManagement>
    <system>continuum</system>
    <url>http://continuum.com</url>
    <notifiers>
      <notifier>
        <configuration>
          <address>[email protected]</address>
        </configuration>
      </notifier>
      <notifier>
        <sendOnError>false</sendOnError>
        <sendOnSuccess>false</sendOnSuccess>
        <sendOnWarning>false</sendOnWarning>
        <configuration>
          <address>[email protected]</address>
          <committers>true</committers>
        </configuration>
      </notifier>
    </notifiers>
  </ciManagement>

=========================================================

The parent POM notifier is completely ignored, even though 
combine.children="append" is supplied.

Tested with Maven 2.2.1 and 3.0.3 without success.

The attempted goal is to have admin to be notified for every event, but the 
developer of certain package (the child) to be notified only should the build 
fail.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to