[
http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269557#action_269557
]
Dennis Lundberg commented on MCHANGES-245:
------------------------------------------
Alan and Benson,
I'm not feeling comfortable with the patch that was applied for a couple of
reasons.
* The new parameter in AnnouncementMojo.java needs an example of how one would
configure the plugin to add mappings.
* The changes to IssueAdapter is not the right way to go. We need to figure out
a way to extract the mapping (default values and such) to a class for a
specific IMS. This patch exposes the current (not so good) implementation, by
adding new public methods. Instead we should create a JIRAAdapter or something
similar that can create a mapping Map, which can be used as an input parameter
for the IssueAdapter class.
For the last two releases of the plugin I've been working to try to abstract
away the IMS implementation details as much as possible into helper classes and
adapters. The goal is to eventually create an IMS API. Therefor I review every
change with that in mind.
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues
> types to "fix", "add" and "update" actions. If the issue type from the IMS
> isn't recognized the default action type is blank and this leads to the issue
> not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA
> installation as is it has a greater range of issue types and can be extended
> with additional types. The most flexible solution for JIRA and other IMSes
> would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
