[
https://jira.codehaus.org/browse/MDEP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279214#comment-279214
]
Olivier Lamy edited comment on MDEP-295 at 9/17/11 2:43 AM:
------------------------------------------------------------
Hello,
Thanks for the patch.
But generally we like to not break backward compat.
And such diff can causes pain :
\- public static String getFormattedFileName( Artifact artifact, boolean
removeVersion, boolean prependGroupId )
\+ public static String getFormattedFileName( Artifact artifact, boolean
removeVersion, boolean removeClassifier, boolean prependGroupId )
IMHO The new parameter must be at the end of the new method and the old method
must be preserve.
Can you take care of this with a new patch ?
Thanks
was (Author: olamy):
Hello,
Thanks for the patch.
But generally we like to not break backward compat.
And such diff can causes pain :
- public static String getFormattedFileName( Artifact artifact, boolean
removeVersion, boolean prependGroupId )
+ public static String getFormattedFileName( Artifact artifact, boolean
removeVersion, boolean removeClassifier, boolean prependGroupId )
IMHO The new parameter must be at the end of the new method and the old method
must be preserve.
Can you take care of this with a new patch ?
Thanks
> Add ability to strip classifier
> -------------------------------
>
> Key: MDEP-295
> URL: https://jira.codehaus.org/browse/MDEP-295
> Project: Maven 2.x Dependency Plugin
> Issue Type: Improvement
> Reporter: Jason Smith
> Assignee: Brian Fox
> Attachments:
> 0002-stripClassifier-option-added-to-the-copy-dependency-.patch, good.patch
>
>
> In addition to the ability to specify that the version be stripped from the
> artifact it would be helpful to be able to specify that the classifier be
> stripped also.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
