WagonHelper.getWagonResourceFetcher does not support HTTPS
----------------------------------------------------------

                 Key: MINDEXER-42
                 URL: https://jira.codehaus.org/browse/MINDEXER-42
             Project: Maven Indexer
          Issue Type: Bug
    Affects Versions: 4.1.2
            Reporter: Jesse Glick
            Priority: Minor


The intent of {{WagonHelper.getWagonResourceFetcher}} is to make it easy to use 
Wagon as a transport when available. In practice, it is useless since it cannot 
handle HTTPS connections.

The workaround is simple - construct a {{WagonFetcher}} directly with the 
desired scheme - but then the existing convenience methods should not be used. 
Recommend deprecating them, and optionally introducing a replacement

{code:java}
    public WagonFetcher getWagonResourceFetcher( final TransferListener 
listener, final String protocol,
                                                 final AuthenticationInfo 
authenticationInfo, final ProxyInfo proxyInfo )
        throws ComponentLookupException
    {
        return new WagonFetcher( plexusContainer.lookup( Wagon.class, protocol 
), listener, authenticationInfo, proxyInfo );
    }
{code}

or

{code:java}
    public WagonFetcher getWagonResourceFetcher( final TransferListener 
listener, final String indexUpdateUrl,
                                                 final AuthenticationInfo 
authenticationInfo, final ProxyInfo proxyInfo )
        throws ComponentLookupException
    {
        return new WagonFetcher( plexusContainer.lookup( Wagon.class, 
URI.create( indexUpdateUrl ).getScheme() ), listener, authenticationInfo, 
proxyInfo );
    }
{code}


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to