[ 
https://jira.codehaus.org/browse/MSHADE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=293807#comment-293807
 ] 

Shane StClair edited comment on MSHADE-111 at 3/11/12 3:23 PM:
---------------------------------------------------------------

Ok, this patch (mshade-111-fixed-again.patch) should be the definitive version. 
Filter include patterns now only apply to the specified artifacts. Please 
delete/disregard the previous patches. This patch should be ready for review 
and application.
                
      was (Author: shane907):
    Ok, this patch should be the definitive version. Filter include patterns 
now only apply to the specified artifacts. Please delete/disregard the previous 
patches. This patch should be ready for review and application.
                  
> minimizeJar should not remove classes specifically included by filters
> ----------------------------------------------------------------------
>
>                 Key: MSHADE-111
>                 URL: https://jira.codehaus.org/browse/MSHADE-111
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 1.5
>            Reporter: Shane StClair
>         Attachments: mshade-111-fixed-again.patch, mshade-111-fixed.patch, 
> mshade-111.patch
>
>
> Currently there is no way to specify classes that should not be removed by 
> minimizeJar. This means that projects using dynamically loaded classes 
> (log4j, for instance) cannot use minimizeJar. This patch prevents minimizeJar 
> from removing classes that were specified for inclusion in a filter.
> The patch also fixes a test in ComponentsXmlResourceTransformerTest that was 
> failing on Windows due to different line breaks in a string comparison.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to