[
https://jira.codehaus.org/browse/MSHARED-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=301509#comment-301509
]
Graham Leggett commented on MSHARED-228:
----------------------------------------
Turned out there were many edge cases not covered by the original code, and
arbitrary assumptions made (such as the closing token only works if it is one
character long), so my only option to fix this was to rewrite the filter
parsing code.
Patch attached, new tests, all existing tests pass.
> MultiDelimiterInterpolatorFilterReaderLineEnding() does not filter after a
> token is escaped
> -------------------------------------------------------------------------------------------
>
> Key: MSHARED-228
> URL: https://jira.codehaus.org/browse/MSHARED-228
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Affects Versions: maven-filtering-1.0
> Environment: java version "1.6.0_33"
> Java(TM) SE Runtime Environment (build 1.6.0_33-b03-424-10M3720)
> Java HotSpot(TM) 64-Bit Server VM (build 20.8-b03-424, mixed mode)
> Reporter: Graham Leggett
>
> When an attempt is made to filter the following string:
> export SERVER_ENV=\${SERVER_ENV:${httpd.server.env}}
> The escape character "\" ends up escaping the entire token, or failing that
> the entire line, and the filter "${httpd.server.env}" is unresolved.
> Expected:
> export SERVER_ENV=${SERVER_ENV:sandbox}
> Actual:
> export SERVER_ENV=${SERVER_ENV:${httpd.server.env}}
> Patch to follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
