[ 
https://jira.codehaus.org/browse/MSITE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=307422#comment-307422
 ] 

Andreas Sewe commented on MSITE-651:
------------------------------------

As shown in the screenshot, the fix has at least one shortcoming: What was 
previously the "Project Documentation" menu now becomes the "reports" menu. 
Likewise, "parent" and "module" should be replaced by proper, localized titles.

That being said, while the fix improves upon the current situation, it is far 
from perfect (IMHO: It doesn't warrant a _Fixed_ for this issue, as per the 
issue's title): Ideally, the empty sections would not show up at all. After 
all, they don't show up in the menu sidebar either, so it seems illogical to 
have them in the sitemap. (I am curious why the menu generation code cannot be 
adapted for sitemap generation.)
                
> Unnecessary "parent" and "modules" menus show up as empty sections in sitemap
> -----------------------------------------------------------------------------
>
>                 Key: MSITE-651
>                 URL: https://jira.codehaus.org/browse/MSITE-651
>             Project: Maven 2.x and 3.x Site Plugin
>          Issue Type: Bug
>    Affects Versions: 3.1
>         Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
>            Reporter: Andreas Sewe
>         Attachments: example.tar.gz, screenshot-1.jpg
>
>
> When using {{generateSitemap}}, the resulting {{sitemap.html}} contains ugly 
> empty sections (empty {{<h4>}}, superfluous {{<hr>}}) if one of the _special_ 
> menus ({{parent}}, {{module}}) is empty as the project in question does not 
> have a parent or modules, respectively.
> The {{sitemap.html}} generated by the attached example project ({{mvn site}}) 
> illustrates this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to