[
https://jira.codehaus.org/browse/SCM-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317822#comment-317822
]
Andrei Pozolotin commented on SCM-709:
--------------------------------------
I took a look. few ideas:
1) "/" feels like a hack; who guarantees its presence ?
2) could you differentiate via all of: File.exists() File.isFile()
File.isDirectory() ?
3) "/" probably should be File.separator ?
4) need File.getCanonicalFile() to guard against symlinks ?
5) need File.getAbsolutePath() to actually render File.separator suffix ?
6) only one of oldFilePath or newFilePath is actually present on file system
for File.exists() to work,
could be logic error in :: if ( status == ScmFileStatus.RENAMED ) {} :: block,
if treating both same way ?
7) if original issue is path/file overlap, may be should detect specifically
only that?
> REGRESSION: git status doesn't work if repository root is not the working
> directory
> -----------------------------------------------------------------------------------
>
> Key: SCM-709
> URL: https://jira.codehaus.org/browse/SCM-709
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-git
> Affects Versions: 1.8, 1.8.1
> Reporter: Robert Scholte
> Assignee: Robert Scholte
> Priority: Blocker
>
> SCM-686 introduced the {{--porcelain}} option to make the {{status}} result
> language independend.
> Without the {{--porcelain}} option files were listed relative to the working
> directory, but with {{--porcelain}} files are listed relative to the
> repository root. In most cases these are the same, but not always.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
