[ 
https://jira.codehaus.org/browse/SUREFIRE-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322367#comment-322367
 ] 

Kristian Rosenvold commented on SUREFIRE-833:
---------------------------------------------

I am slightly sceptical to this patch overall since we're going a bit far into 
"being" a test framework. I'd like to see this discussed within the junit 
project before creating all kinds of surefire specific junit extensions.

I know this has been discussed within JUnit. At the time it seemed to be like 
they were considering doing /more/ of the annotation processing within the 
framework and less within the runner. I believe there's already more options 
for doing annotation processing within junit (which we dont use)

Please start this discussion on the junit mailing list and we'll take it from 
there


                
> Support for annotated JUnit @Category
> -------------------------------------
>
>                 Key: SUREFIRE-833
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-833
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Junit 4.x support
>    Affects Versions: 2.12
>            Reporter: Jan Goyvaerts
>             Fix For: 2.15
>
>         Attachments: SUREFIRE-833-spraguep-2.patch, 
> SUREFIRE-833-spraguep.patch
>
>
> The current implementation of Surefire seems to look for explicit @Category 
> annotations in the test classes. And will only consider those. Suppose I'd 
> like to add a more concise annotation for this:
> @Category(IntegrationTests.class) <== JUnit @Category
> @Target({ElementType.TYPE})
> @Retention(RetentionPolicy.RUNTIME)
> @Documented
> public @interface IntegrationTest {}
> Annotating my test class with @IntegrationTest does not work. Although I 
> think it looks much better than repeating everywhere in my code 
> "@Category(com.foo.bar.IntegrationTests.class)". For which I add an 
> additional dependency in the interface class btw.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to