[ 
https://jira.codehaus.org/browse/SCM-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=329588#comment-329588
 ] 

Matthieu Lecoutre edited comment on SCM-695 at 7/30/13 8:14 AM:
----------------------------------------------------------------

Reproduced with latest version of the release plugin at this time
 * maven-release-plugin:2.4.1
 * maven-scm-plugin:1.8.1
 * git version 1.8.3.msysgit.0
 * Maven 3.0.4 (not the last one, but will not change anything i assumed)
 * windows environment 

L:\data\gitrepo\mqbuffer\

my modules names:
[INFO] mqbuffer
[INFO] mqbuffer-properties
[INFO] mqbuffer-coordination
[INFO] mqbuffer-business
[INFO] mqbuffer-web
[INFO] mqbuffer-ear
[INFO] mqbuffer-api
[INFO] mqbuffer-cleaner

UPDATE of my first remark
I've done some additional tests.

and i've changed folder's names of my modules (keeping the same artifactId, 
only change the folder)

mqbuffer-properties becoming mqbufferProperties and other modules on the same 
model

the behaviour the the "git add cmd" is similar and just keep the second word 
EVEN if i don't use - the name
[INFO] [INFO]
[INFO] [INFO] mqbuffer .......................................... SUCCESS 
[0.422s]
[INFO] [INFO] mqbuffer-properties ............................... SUCCESS 
[1.594s]
[INFO] [INFO] mqbuffer-coordination ............................. SUCCESS 
[4.643s]
[INFO] [INFO] mqbuffer-business ................................. SUCCESS 
[8.691s]
[INFO] [INFO] mqbuffer-web ...................................... SUCCESS 
[17.804s]
[INFO] [INFO] mqbuffer-ear ...................................... SUCCESS 
[1.985s]
[INFO] [INFO] mqbuffer-api ...................................... SUCCESS 
[2.563s]
[INFO] [INFO] mqbuffer-cleaner .................................. SUCCESS 
[1.829s]
[INFO] [INFO] 
------------------------------------------------------------------------
[INFO] [INFO] BUILD SUCCESS
[INFO] [INFO] 
------------------------------------------------------------------------
[INFO] [INFO] Total time: 39.922s
[INFO] [INFO] Finished at: Tue Jul 30 14:18:18 CEST 2013
[INFO] [INFO] Final Memory: 9M/23M
[INFO] [INFO] 
------------------------------------------------------------------------
[INFO] Checking in modified POMs...
[INFO] Executing: cmd.exe /X /C "git add -- pom.xml 
{color:red}Properties{color}\pom.xml  {color:red}Coordination{color}\pom.xml 
{color:red}Business{color}\pom.xml {color:red}Web{color}\pom.xml 
{color:red}Ear{color}\pom.xml {color:red}Api{color}\pom.xml 
{color:red}Cleaner{color}\pom.xml"
[INFO] Working directory: L:\data\gitrepo\mqbuffer\mqbuffer
[INFO] ------------------------------------------------------------------------


i've forked the https://github.com/olamy/maven-scm projet in order to create a 
test to reproduce the error, but i'm not sure this a clear mirror of the apache 
version.
if i don't make any mistake, we should have a loop per file to add in the git 
repository on windows environment already in the 1.8 version
{code:title= 
org.apache.maven.scm.provider.git.gitexe.command.add.GitAddCommand.java 
|borderStyle=solid}
   private AddScmResult executeAddFileSet( ScmFileSet fileSet )
        throws ScmException
    {
        File workingDirectory = fileSet.getBasedir();
        List<File> files = fileSet.getFileList();

        // command line can be too long for windows so add files individually 
(see SCM-697)
        if ( Os.isFamily( Os.FAMILY_WINDOWS ) )
        {
            for ( File file : files )
            {
                AddScmResult result = executeAddFiles( workingDirectory, 
Collections.singletonList( file ) );

                if ( result != null )
                {
                    return result;
                }
            }
        }
// ...
{code}

if i use now  a no flat structure as the previous comment says, everything 
works fine.

Executing: cmd.exe /X /C "git add -- pom.xml mqbuffer-properties\pom.xml 
mqbuffer-coordination\pom.xml mqbuffer-business\pom.xml mqbuffer-web\pom.xml 
mqbuffer-ear\pom.xml mqbuffer-api\pom.xml mqbuffer-cleaner\pom.xml"
                
      was (Author: mlecoutre):
    Reproduced with latest version of the release plugin at this time
 * maven-release-plugin:2.4.1
 * maven-scm-plugin:1.8.1
 * git version 1.8.3.msysgit.0
 * Maven 3.0.4 (not the last one, but will not change anything i assumed)
 * windows environment 

L:\data\gitrepo\mqbuffer\

my modules names:
[INFO] mqbuffer
[INFO] mqbuffer-properties
[INFO] mqbuffer-coordination
[INFO] mqbuffer-business
[INFO] mqbuffer-web
[INFO] mqbuffer-ear
[INFO] mqbuffer-api
[INFO] mqbuffer-cleaner

UPDATE of my first remark
I've done some additional tests.

and i've changed folder's names of my modules (keeping the same artifactId, 
only change the folder)

mqbuffer-properties becoming mqbufferProperties and other modules on the same 
model

the behaviour the the "git add cmd" is similar and just keep the second word 
EVEN if i don't use - the name
[INFO] [INFO]
[INFO] [INFO] mqbuffer .......................................... SUCCESS 
[0.422s]
[INFO] [INFO] mqbuffer-properties ............................... SUCCESS 
[1.594s]
[INFO] [INFO] mqbuffer-coordination ............................. SUCCESS 
[4.643s]
[INFO] [INFO] mqbuffer-business ................................. SUCCESS 
[8.691s]
[INFO] [INFO] mqbuffer-web ...................................... SUCCESS 
[17.804s]
[INFO] [INFO] mqbuffer-ear ...................................... SUCCESS 
[1.985s]
[INFO] [INFO] mqbuffer-api ...................................... SUCCESS 
[2.563s]
[INFO] [INFO] mqbuffer-cleaner .................................. SUCCESS 
[1.829s]
[INFO] [INFO] 
------------------------------------------------------------------------
[INFO] [INFO] BUILD SUCCESS
[INFO] [INFO] 
------------------------------------------------------------------------
[INFO] [INFO] Total time: 39.922s
[INFO] [INFO] Finished at: Tue Jul 30 14:18:18 CEST 2013
[INFO] [INFO] Final Memory: 9M/23M
[INFO] [INFO] 
------------------------------------------------------------------------
[INFO] Checking in modified POMs...
[INFO] Executing: cmd.exe /X /C "git add -- pom.xml 
{color:red}Properties{color}\pom.xml  {color:red}Coordination{color}\pom.xml 
{color:red}Business{color}\pom.xml {color:red}Web{color}\pom.xml 
{color:red}Ear{color}\pom.xml {color:red}Api{color}\pom.xml 
{color:red}Cleaner{color}\pom.xml"
[INFO] Working directory: L:\data\gitrepo\mqbuffer\mqbuffer
[INFO] ------------------------------------------------------------------------


i've forked the https://github.com/olamy/maven-scm projet in order to create a 
test to reproduce the error, but i'm not sure this a clear mirror of the apache 
version.
if i don't make any mistake, we should have a loop per file to add in the git 
repository on windows environment already in the 1.8 version
{code:title= 
org.apache.maven.scm.provider.git.gitexe.command.add.GitAddCommand.java 
|borderStyle=solid}
   private AddScmResult executeAddFileSet( ScmFileSet fileSet )
        throws ScmException
    {
        File workingDirectory = fileSet.getBasedir();
        List<File> files = fileSet.getFileList();

        // command line can be too long for windows so add files individually 
(see SCM-697)
        if ( Os.isFamily( Os.FAMILY_WINDOWS ) )
        {
            for ( File file : files )
            {
                AddScmResult result = executeAddFiles( workingDirectory, 
Collections.singletonList( file ) );

                if ( result != null )
                {
                    return result;
                }
            }
        }
// ...
{code}


                  
> Mvn release plugin problems with too many - in name
> ---------------------------------------------------
>
>                 Key: SCM-695
>                 URL: https://jira.codehaus.org/browse/SCM-695
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-git
>    Affects Versions: 1.7
>         Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100)
> Maven home: /home/devent/apps/apache-maven-3.0.3
> Java version: 1.7.0_b147-icedtea, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.1/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.1.9-1.fc16.i686", arch: "i386", family: "unix"
>            Reporter: Erwin Mueller
>            Priority: Blocker
>         Attachments: mvn-release-prepare.log
>
>
> Have maven problems with modules containing too many "-"?
> I have projects that are named:
> globalpom-groovy/
> globalpom-groovy/globalpom-groovy/pom.xml < parent pom
> globalpom-groovy/globalpom-groovy-izpack/pom.xml
> globalpom-groovy/globalpom-groovy-izpack-snglejar/pom.xml
> globalpom-groovy/globalpom-groovy-testutils/pom.xml
> But if I do mvn release:prepare inside of globalpom-groovy/globalpom-groovy/, 
> then I get the error:
> [INFO] Executing: /bin/sh -c cd 
> /mnt/read/projects/com.anrisoftware/globalpom/globalpom-groovy/globalpom-
> groovy && git add -- pom.xml -izpack/pom.xml -izpack-singlejar/pom.xml -
> testutils/pom.xml
> [INFO] Working directory: 
> /mnt/read/projects/com.anrisoftware/globalpom/globalpom-groovy/globalpom-
> groovy
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Global POM Groovy ................................. FAILURE [12.365s]
> [INFO] Global POM Groovy IzPack .......................... SKIPPED
> [INFO] Global POM Groovy IzPack Single Jar ............... SKIPPED
> [INFO] Global POM Groovy Test Utilities .................. SKIPPED
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 13.066s
> [INFO] Finished at: Sat Jan 21 15:45:50 CET 2012
> [INFO] Final Memory: 12M/152M
> [INFO] 
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-
> plugin:2.0:prepare (default-cli) on project globalpom-groovy: Unable to 
> commit 
> files
> [ERROR] Provider message:
> [ERROR] The git-add command failed.
> [ERROR] Command output:
> [ERROR] fatal: pathspec 'globalpom-groovy/-izpack/pom.xml' did not match any 
> files
> Of course that's wrong 'globalpom-groovy/-izpack/pom.xml' should be 
> '../globalpom-groovy-izpack/pom.xml', or something like that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to