[ 
https://jira.codehaus.org/browse/MCHECKSTYLE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg closed MCHECKSTYLE-166.
-------------------------------------

    Resolution: Won't Fix
      Assignee: Mark Struberg

The maven-checkstyle-plugin supports loading the checkstyle rule from a 
dependency (see documentation about multi-module builds and creating a custom 
build-tools.jar). For this to work we need to resolve the list of dependencies 
first.
Please note that the dependency resolution itself does not cost much these days 
anymore.

> Drop @requiresDependencyResolution test
> ---------------------------------------
>
>                 Key: MCHECKSTYLE-166
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-166
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8
>         Environment: N/A
>            Reporter: Ernst de Haan
>            Assignee: Mark Struberg
>            Priority: Minor
>
> Currently, the 
> [{{CheckstyleViolationCheckMojo}}|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.8/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java?revision=1188083&view=markup]
>  class declares:{code}@requiresDependencyResolution test{code}However, that 
> should not be necessary. Checkstyle works on source files, not on bytecode.
> If this declaration would be removed, then this Checkstyle plugin should 
> still work perfectly fine (I would expect without any further code changes).
> The advantage would be that in our Continuous Integration pipeline I can skip 
> the _compile_ stage and immediately trigger the _checkstyle_ stage. That 
> would save us multiple minutes on the feedback roundtrip.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to