[ 
https://jira.codehaus.org/browse/MRESOURCES-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=354215#comment-354215
 ] 

Dan Tran commented on MRESOURCES-186:
-------------------------------------

I ran into this issue after upgrade from 2.6 to 2.7, my build fails b/c my 
resources directory has binary files.  This is a regression, isn't it? and 
critical as well since now I can upgrade unless i have do specific file 
filtering. The resource-able files are scatter in my resources directory and it 
is tough to maintain.  

Can we find out why the feature got removed( ie able to detect binary file an 
skip filtering?)

> Improve error handling based on Mark invalid
> --------------------------------------------
>
>                 Key: MRESOURCES-186
>                 URL: https://jira.codehaus.org/browse/MRESOURCES-186
>             Project: Maven Resources Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.7
>            Reporter: Karl-Heinz Marbaise
>            Priority: Minor
>             Fix For: 2.8
>
>
> Sometimes it can happen that filtering is done on files which shouldn't be 
> filtered...which results in the following:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-resources-plugin:2.7:resources 
> (default-resources) on project OrionCommunity: Mark invalid -> [Hel
> p 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-resources-plugin:2.7:resources 
> (default-resources)
>  on project OrionCommunity: Mark invalid
>         at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
>         at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>         at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>         at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>         at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>         at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>         at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
>         at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
>         at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
>         at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>         at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>         at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
>         at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
>         at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
>         at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Mark invalid
>         at 
> org.apache.maven.plugin.resources.ResourcesMojo.execute(ResourcesMojo.java:306)
>         at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
>         at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
>         ... 19 more
> Caused by: org.apache.maven.shared.filtering.MavenFilteringException: Mark 
> invalid
>         at 
> org.apache.maven.shared.filtering.DefaultMavenFileFilter.copyFile(DefaultMavenFileFilter.java:129)
>         at 
> org.apache.maven.shared.filtering.DefaultMavenResourcesFiltering.filterResources(DefaultMavenResourcesFiltering.java:264)
>         at 
> org.apache.maven.plugin.resources.ResourcesMojo.execute(ResourcesMojo.java:300)
>         ... 21 more
> Caused by: java.io.IOException: Mark invalid
>         at java.io.BufferedReader.reset(BufferedReader.java:485)
>         at 
> org.apache.maven.shared.filtering.MultiDelimiterInterpolatorFilterReaderLineEnding.read(MultiDelimiterInterpolatorFilterReaderLineEnding.java:416)
>         at 
> org.apache.maven.shared.filtering.MultiDelimiterInterpolatorFilterReaderLineEnding.read(MultiDelimiterInterpolatorFilterReaderLineEnding.java:205)
>         at java.io.Reader.read(Reader.java:123)
>         at org.apache.maven.shared.utils.io.IOUtil.copy(IOUtil.java:181)
>         at org.apache.maven.shared.utils.io.IOUtil.copy(IOUtil.java:168)
>         at 
> org.apache.maven.shared.utils.io.FileUtils.copyFile(FileUtils.java:1856)
>         at 
> org.apache.maven.shared.utils.io.FileUtils.copyFile(FileUtils.java:1804)
>         at 
> org.apache.maven.shared.filtering.DefaultMavenFileFilter.copyFile(DefaultMavenFileFilter.java:114)
> {code}
> Currently this only crashes the build. But it might be better to create an 
> appropriate error message for the user.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to