[ 
https://jira.codehaus.org/browse/MSHARED-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=356374#comment-356374
 ] 

Rubén Suárez Alvarez commented on MSHARED-385:
----------------------------------------------

What do yo mean with "We use the manifest class from the JDK"?
As far as I can see, you use own implementation: 
https://github.com/sonatype/plexus-archiver/blob/master/src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java#L89

The JAR Manfiest spec 
(https://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html#JAR_Manifest
 - the link in org/codehaus/plexus/archiver/jar/Manifest.java javadoc is broken 
- ) states that you can use CR LF | LF | CR (not followed by LF) as new line 
characters.

> Specify lineEnding style in Plexus Archiver
> -------------------------------------------
>
>                 Key: MSHARED-385
>                 URL: https://jira.codehaus.org/browse/MSHARED-385
>             Project: Maven Shared Components
>          Issue Type: New Feature
>          Components: maven-archiver
>            Reporter: Rubén Suárez Alvarez
>            Priority: Minor
>
> From: https://bugs.eclipse.org/bugs/show_bug.cgi?id=452123
> MANIFEST.MF generation is delegated to 
> https://maven.apache.org/shared/maven-archiver/ which eventually relies on
> https://github.com/sonatype/plexus-archiver/blob/master/src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java#L89
> There's no way to set custom EOL anywhere in the process.
> In Maven Assembly Plugin 
> (http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html) you can 
> use "lineEnding" element but you can't set it in anyway in plexus archiver.
> If It can't be specified via configuration, at least default system line end 
> style (System.getProperty("line.separator")) should be used.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to