[ 
https://jira.codehaus.org/browse/MPIR-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358296#comment-358296
 ] 

Christian Schulte commented on MPIR-238:
----------------------------------------

I am going to delete the patches. This issue needs more discussion. In Maven 3, 
the core got changed to fall back to loose class files from {{target/classes}} 
directories to solve various issues. However, this leads to issues with 
projects where the content of  the {{target/classes}} directory does not match 
the content of e.g. the {{jar}} file the project produces. A project using the 
{{maven-shade-plugin}} may produce a {{jar}} with totally different content 
than the content of the {{target/classes}} directory. The {{maven-jar-plugin}} 
may be configured to exclude various files from the {{target/classes}} 
directory. The {{clirr-maven-plugin}} must not compare the content of the 
{{target/classes}} directory with the {{jar}} of the previous version etc. My 
suggestion is to fall back to loose class files only if falling back really is 
the only way to not fail the build. If the packaged artifact is available, 
there is no need to fall back to anything, in my opinion. Also, I don't think 
{{hasLifecyclePhase}} should be backing  this decision since you cannot tell 
how a project performs its packaging.

> Dependency File Details section of the dependencies report shows 
> 'target/classes' for reactor artifacts.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MPIR-238
>                 URL: https://jira.codehaus.org/browse/MPIR-238
>             Project: Maven Project Info Reports Plugin
>          Issue Type: Bug
>          Components: dependency-info
>    Affects Versions: 2.4
>            Reporter: Christian Schulte
>            Priority: Minor
>         Attachments: MPIR-238-ReactorReader.patch, 
> MPIR-238-ReactorReader.patch
>
>
> Generating the dependencies report in a multi-module project leads to 
> incorrect entries in the 'Dependency File Details' section of the 
> dependencies report. For example, the [Maven Release Plugin Dependency File 
> Details|http://maven.apache.org/plugins/maven-release-plugin/dependencies.html#Dependency_File_Details]
>  report contains the following entry: 
> ||Filename||Size||Entries||Classes||Packages||JDK Rev||Debug||
> |maven-release-manager/target/classes|-|0|0|0|-|release|
> Building the site of a single module ('mvn site' in that modules directory), 
> the correct entries are shown.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to