[ 
https://jira.codehaus.org/browse/MPIR-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359397#comment-359397
 ] 

Michael Osipov commented on MPIR-263:
-------------------------------------

OK, I re-read you comment and checked the commit for MPLUGIN-279. What I would 
like to see for this plugin and others (MPMD, MJAVADOC) is a helper class which 
returns {{sourceJavaVersion}} and {{targetJavaVersion}}.

E .g.:

{code}
public class JavaVersionHelper /* I am not tied to this name though */ {

  public static getSourceJavaVersion(MavenProject project) {
    // Logic from MPLUGIN
  }

  public static getTargetJavaVersion(MavenProject project) {
    // Logic from MPLUGIN
  }
{code}

When this logic is merged into a shared component, this class can be safely 
deleted from all plugins and shared comp simply imported.

How does that sound?

> Add parameter 'targetJavaVersion' and inject ${maven.compiler.target}
> ---------------------------------------------------------------------
>
>                 Key: MPIR-263
>                 URL: https://jira.codehaus.org/browse/MPIR-263
>             Project: Maven Project Info Reports Plugin
>          Issue Type: Improvement
>          Components: summary
>    Affects Versions: 2.6
>         Environment: Maven 2.2.1 and 3.0.3
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>             Fix For: 2.8
>
>
> If you define {{maven.compiler.target}} in the {{<properties>}} section or 
> per command line, that value is not taken into account in report generation. 
> The source and target version are retrieved from the static model.
> If someone could use an interpolated model that would solve the issue. At 
> least this should be in the FAQ list.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to