[
https://issues.apache.org/jira/browse/MESOS-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062553#comment-14062553
]
Benjamin Hindman commented on MESOS-1593:
-----------------------------------------
Responses to questions from [~vinodkone] at MESOS-1524:
{quote}
Is the plan to kill ContainerInfo from CommandInfo in favor of DockerInfo?
{quote}
It was still unclear. One use case we're still considering is letting a
containerizer construct a container with a non-Docker image, e.g., a tar.gz.
You could imagine making the CommandInfo take either a ContainerInfo or a
DockerInfo, but the nice thing about keeping the CommandInfo simple is that
it's easy to use as an interface just for "commands". For example, at one point
we added HealthCheck to the CommandInfo which was unfortunate because there
were some use cases where we wanted to use CommandInfo as the interface to
something but we didn't want you to be able to set the HealthCheck field. I
think the same thing applies with ContainerInfo and DockerInfo here, which is
why we're suggesting pulling them out into either ExecutorInfo or TaskInfo.
{quote}
What user is the docker container launched as? If its customizable, you need to
have a 'user' field in there.
{quote}
Great point! We should add a 'user' field. Continuing with the conversation
before, you could imagine making the "command" of a DockerInfo just be a
CommandInfo, but given that it contains ContainerInfo and others we decided to
replicate some of the functionality here. See the next response too.
{quote}
Why do you need "repeated string args"? Why can't it be just part of the
"command" string?
{quote}
We have the ability to pass an argv style array to Docker so we'd like to
expose that so people (or we) don't have to do crazy quoting.
{quote}
What is the rationale for DockerInfo to be alongside CommandInfo instead of
replacing ContainerInfo?
{quote}
See this
[comment|https://issues.apache.org/jira/browse/MESOS-1524?focusedCommentId=14039893&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14039893].
> Add DockerInfo Configuration
> ----------------------------
>
> Key: MESOS-1593
> URL: https://issues.apache.org/jira/browse/MESOS-1593
> Project: Mesos
> Issue Type: Task
> Reporter: Timothy Chen
> Assignee: Timothy Chen
>
> We want to add a new proto message to encapsulate all Docker related
> configurations into DockerInfo.
> Here is the document that describes the design for DockerInfo:
> https://github.com/tnachen/mesos/wiki/DockerInfo-design
--
This message was sent by Atlassian JIRA
(v6.2#6252)
