[ 
https://issues.apache.org/jira/browse/MESOS-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104282#comment-14104282
 ] 

Jay Buffington commented on MESOS-1724:
---------------------------------------

I'm running a private docker registry on port 80 at 
docker-registry.example.com.  I've uploaded an image to that registry, so I can 
now use it by running "docker run docker-registry.example.com:80/centos:6u5"

Note that 80 is the default port, so for my case, I can simply remove it.  That 
said, it is valid to run a docker registry on any port, so the docker 
containerizer should support that.

This issue could be resolved by modifying the DockerContainerizerProcess::pull 
method to scan the string starting from the end and stopping when it 
encountered the first colon instead of using string::split.

> Can't include port in DockerInfo's image
> ----------------------------------------
>
>                 Key: MESOS-1724
>                 URL: https://issues.apache.org/jira/browse/MESOS-1724
>             Project: Mesos
>          Issue Type: Bug
>          Components: containerization
>            Reporter: Jay Buffington
>            Assignee: Timothy Chen
>            Priority: Minor
>              Labels: docker
>
> The current git tree doesn't allow you to specify a docker image with 
> multiple colons.  It is valid that multiple colons would exist in a docker 
> image.  e.g. docker-registry.example.com:80/centos:6u5
> From 
> https://github.com/apache/mesos/blob/02a35ab213fb074f6c532075cada76f13eb9d552/src/slave/containerizer/docker.cpp#L441
> {code}
>   vector<string> parts = strings::split(dockerInfo.image(), ":");
>   if (parts.size() > 2) {
>     return Failure("Not expecting multiple ':' in image: " +
>                    dockerInfo.image());
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to