[ 
https://issues.apache.org/jira/browse/MESOS-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129546#comment-14129546
 ] 

Cody Maloney commented on MESOS-1739:
-------------------------------------

[~vinodkone]: New review request (https://reviews.apache.org/r/25525/). Updated 
the bug title.

Tests now pass. All functionality is there. All comments are incorporated 
except the patch still allows both resources and attributes to be set to 
supersets of what they currently are. 

In the case where someone has a setup where they have a critical negative 
attribute check, they should be aware of that and just not ever add that 
attribute at runtime (They can always fully kill the slave then restart). 
Changing the recover behavior in this case doesn't break their setups, and 
there are a number of cases where we would like increasing attribute sets. The 
check is in one place, and would be one line to change / remove / make be 
identical if that is a hard requirement.

> Allow slave reconfiguration on restart
> --------------------------------------
>
>                 Key: MESOS-1739
>                 URL: https://issues.apache.org/jira/browse/MESOS-1739
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Patrick Reilly
>            Assignee: Cody Maloney
>
> Make it so that either via a slave restart or a out of process "reconfigure" 
> ping, the attributes and resources of a slave can be updated to be a superset 
> of what they used to be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to