[ 
https://issues.apache.org/jira/browse/MESOS-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143745#comment-14143745
 ] 

Dominic Hamon commented on MESOS-1456:
--------------------------------------

Discarding a future when it cannot possibly be satisfied seems reasonable to me.

We check if the process is already in a terminating state when enqueuing the 
dispatch event and delete the event if it is. Should the Future also be 
discarded in this case, as the Future will not be satisfied?

> Metric lifetime should be tied to process runstate, not lifetime.
> -----------------------------------------------------------------
>
>                 Key: MESOS-1456
>                 URL: https://issues.apache.org/jira/browse/MESOS-1456
>             Project: Mesos
>          Issue Type: Bug
>          Components: statistics
>    Affects Versions: 0.19.0
>            Reporter: Dominic Hamon
>
> The usual pattern for termination of processes is {{terminate(..); wait(..); 
> delete ..;}} but the {{SchedulerProcess}} is terminated and then deleted some 
> time later.
> If the metrics endpoint is accessed within that period, it never returns as 
> it tries to access a {{Gauge}} that has a reference to a valid PID that is 
> not getting any timeslices (the {{SchedulerProcess}}). A one-off fix can be 
> made to the {{SchedulerProcess}} to move the metrics add/remove calls to 
> {{initialize}} and {{finalize}}, but this should be the general pattern for 
> every process with metrics. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to