[
https://issues.apache.org/jira/browse/MESOS-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153331#comment-14153331
]
Dominic Hamon commented on MESOS-1291:
--------------------------------------
ideally, we would have just the clang-format file and it would handle
everything. we would then just have a check at commit that there are no style
errors by running clang-format and checking nothing changed.
However, the variable naming is a tricky one as it's not caught by
clang-format, so we would still keep the lint check for that. However, that
could also just be a precommit check and then developers shouldn't care so much
:)
> Use clang-format to automatically format code to style
> ------------------------------------------------------
>
> Key: MESOS-1291
> URL: https://issues.apache.org/jira/browse/MESOS-1291
> Project: Mesos
> Issue Type: Improvement
> Components: technical debt
> Reporter: Dominic Hamon
> Assignee: Michael Park
> Labels: style
>
> Instead of relying on a script to check and report style errors, we should
> move to a workflow that allows people to write code how they feel comfortable
> and then automatically format it to conform to our style guide.
> The Chromium style from clang-format
> (http://clang.llvm.org/docs/ClangFormat.html) is very close to our style
> except for the dropped braces on class, struct, and function definitions, and
> two lines of whitespace between method definitions outside a class. As such,
> we should consider adopting clang-format and patching it to include a Mesos
> style variant.
> It can be run as part of post-reviews or as a git commit hook, or manually
> from within editors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
