[
https://issues.apache.org/jira/browse/MESOS-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158393#comment-14158393
]
Anindya Sinha commented on MESOS-1835:
--------------------------------------
IMO, I think checking __ip__ against 16777343 would break functionality on big
endian systems.
Ideally, one should work in host order format, ie. irrespective of endianness,
the host order representation of the network ordered data should be good for a
specific platform. So, either a check on ntohl(__ip__) == 2130706433, or
checking against string representation of the network ordered IP address (via
inet_ntop) should work.
> Check for IP address being localhost not platform independent
> -------------------------------------------------------------
>
> Key: MESOS-1835
> URL: https://issues.apache.org/jira/browse/MESOS-1835
> Project: Mesos
> Issue Type: Bug
> Components: libprocess
> Affects Versions: 0.20.1
> Reporter: Anindya Sinha
> Assignee: Evelina Dumitrescu
>
> In process::initialize() [3rdparty/src/libprocess/process.cpp], check for
> __ip__ for localhost (127.0.0.1) is done by checking if __ip__ == 2130706433.
> However, it could be either 2130706433 or 16777343 depending on endianness.
> This check should succeed independent of the endianness, so would be good to
> do a 'inet_ntop' and then compare against the string for 127.0.0.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
