[
https://issues.apache.org/jira/browse/MESOS-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158605#comment-14158605
]
Jie Yu commented on MESOS-1861:
-------------------------------
Dominic, I think most of our shared_ptr usage in Mesos code base can be
converted to unique_ptr. Yeah, we have lot of use of shared_ptr in libprocess.
But that's for expert only:)
I agree with you that unless we have a very strong reason to use shared_ptr, we
should use process::Shared and Owned (unique_ptr) instead.
{noformat}
[tw-mbp-jyu mesos (master)]$ grep -r shared_ptr src/
src//linux/routing/internal.hpp: memory::shared_ptr<Data> data;
src//master/http.cpp: foreach (const memory::shared_ptr<Task>& task,
framework.completedTasks) {
src//master/http.cpp: foreach (const memory::shared_ptr<Framework>&
framework,
src//master/http.cpp: foreach (const memory::shared_ptr<Framework>& framework,
src//master/http.cpp: foreach (const memory::shared_ptr<Task>& task,
framework->completedTasks) {
src//master/master.cpp:using memory::shared_ptr;
src//master/master.cpp: foreach (const shared_ptr<Framework>& framework,
frameworks.completed) {
src//master/master.cpp: foreach (const shared_ptr<Framework>& framework,
frameworks.completed) {
src//master/master.cpp:
frameworks.completed.push_back(shared_ptr<Framework>(framework));
src//master/master.hpp: boost::circular_buffer<memory::shared_ptr<Framework>
> completed;
src//master/master.hpp:
completedTasks.push_back(memory::shared_ptr<Task>(new Task(task)));
src//master/master.hpp: boost::circular_buffer<memory::shared_ptr<Task> >
completedTasks;
src//slave/http.cpp: foreach (const memory::shared_ptr<Task>& task,
executor.completedTasks) {
src//slave/slave.cpp: foreach (const memory::shared_ptr<Task>& task,
src//slave/slave.cpp: completedTasks.push_back(memory::shared_ptr<Task>(task));
src//slave/slave.hpp: boost::circular_buffer<memory::shared_ptr<Task> >
completedTasks;
{noformat}
> deprecate process::Shared
> -------------------------
>
> Key: MESOS-1861
> URL: https://issues.apache.org/jira/browse/MESOS-1861
> Project: Mesos
> Issue Type: Improvement
> Components: libprocess
> Reporter: Dominic Hamon
> Priority: Minor
> Labels: c++11, newbie
>
> Deprecate {{process::Shared}} in favour of {{std::shared_ptr}} or
> {{std::tr1::shared_ptr}} from stout/memory.hpp.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
