[ 
https://issues.apache.org/jira/browse/MESOS-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166499#comment-14166499
 ] 

Adam B commented on MESOS-1893:
-------------------------------

Won't we also need an authentication/authenticatee/flatfile tree? Shouldn't it 
be authentication/flatfile/authenticat[or|ee] instead? Then the interface could 
live at authentication/authenticat[or|ee].hpp. Seems like (almost?) every 
authentication mechanism between the master and a slave/framework will have an 
authenticator and authenticatee, so it makes sense to group them together (even 
as different interfaces/"kinds" in the same module).

I also question if "flatfile" is the most appropriate name for the existing 
authenticator. I think "cram_md5" is appropriate enough, since that's the sasl 
mechanism that's hardcoded into the authenticator. The "flatfile" actually 
refers to how the user/pass is given to Mesos (from a flatfile whose path is 
specified on the command-line), and may be unrelated to how it is authenticated.



> Authenticator Module: Location and Naming
> -----------------------------------------
>
>                 Key: MESOS-1893
>                 URL: https://issues.apache.org/jira/browse/MESOS-1893
>             Project: Mesos
>          Issue Type: Improvement
>          Components: modules
>            Reporter: Till Toenshoff
>            Assignee: Till Toenshoff
>            Priority: Blocker
>
> h4. Motivation
> Render a well structured and mesos-alike naming and folder tree. This shall 
> be similar to what we know from the awesome! containerizer structure.
> h4. Folder Structure
> For the flat-file Authenticator Module but also for authentication as a 
> whole, I would like to propose the following structural changes:
> - move {{authenticator.hpp}} out of {{sasl/}}
> - create a new {{authentication/}}
> - create a new {{authentication/authenticator/}}
> -- put the module interface here and name it {{authenticator.hpp}}
> - create a new {{authentication/authenticator/flatfile/}}
> -- put the module implementation here and name it {{authenticator.hpp}} 
> -- mind that I am proposing {{flatfile}} instead of {{sasl}} due to the fact 
> that sasl offers many more mechanisms but our current default (CRAM-MD5) and 
> further dividing the tree into sasl and non-sasl based authentications may be 
> too verbosive/bloated.
> h4. Module Naming
> Following the module naming scheme, I would like to propose 
> {{org_apache_mesos_authenticator_flatfile}} to be used for our first/default 
> Authenticator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to