[
https://issues.apache.org/jira/browse/MESOS-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181986#comment-14181986
]
Evelina Dumitrescu edited comment on MESOS-1919 at 10/23/14 9:20 PM:
---------------------------------------------------------------------
So far have been proposed two ideas:
- __int128_t/__uint128_t types from gcc. Gcc supports this since the 4.6
release.
https://gcc.gnu.org/gcc-4.6/changes.html
- std::vector of unsigned char/integers. If we choose this approach, we could
know easier the family type of the protocol by the size of the vector (eg: IPv4
will have 4 bytes length, IPv6 will have 16).
Which of these options should we decide on ?
was (Author: evelinad):
So far have been proposed two ideas:
- __int128_t/__uint128_t types from gcc. Gcc supports this since the 4.6
release.
https://gcc.gnu.org/gcc-4.6/changes.html
- std::vector of unsigned char. If we choose this approach, we could know
easier the family type of the protocol by the size of the vector (eg: IPv4 will
have 4 bytes length, IPv6 will have 16).
Which of these options should we decide on ?
> Create IP address abstraction
> -----------------------------
>
> Key: MESOS-1919
> URL: https://issues.apache.org/jira/browse/MESOS-1919
> Project: Mesos
> Issue Type: Task
> Components: libprocess
> Reporter: Dominic Hamon
> Assignee: Evelina Dumitrescu
> Priority: Minor
>
> in the code many functions need only the ip address to be passed as a
> parameter. I don't think it would be desirable to use a struct
> SockaddrStorage (MESOS-1916).
> Consider using a {{std::vector<unsigned char>}} (see {{typedef
> std::vector<unsigned char> IPAddressNumber;}} in the Chromium project)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
