[ 
https://issues.apache.org/jira/browse/MESOS-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183690#comment-14183690
 ] 

Evelina Dumitrescu commented on MESOS-1919:
-------------------------------------------

I wanted to use struct IPAddress only for storage and create all the abstaction 
needed in the IPEndPoint class and the callsites will use only the metods from 
the IPEndPoint class. It might be better to use this representation because the 
networking calls(ie inet_ntop, inet_pton) work with in_addr and in6_addr 
structs. Otherwise, we need to convert the vector to this type of structs each 
time.

> Create IP address abstraction
> -----------------------------
>
>                 Key: MESOS-1919
>                 URL: https://issues.apache.org/jira/browse/MESOS-1919
>             Project: Mesos
>          Issue Type: Task
>          Components: libprocess
>            Reporter: Dominic Hamon
>            Assignee: Evelina Dumitrescu
>            Priority: Minor
>
> in the code many functions need only the ip address to be passed as a 
> parameter. I don't think it would be desirable to use a struct 
> SockaddrStorage (MESOS-1916).
> Consider using a {{std::vector<unsigned char>}} (see {{typedef 
> std::vector<unsigned char> IPAddressNumber;}} in the Chromium project)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to