[
https://issues.apache.org/jira/browse/MESOS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185974#comment-14185974
]
Kapil Arya commented on MESOS-1997:
-----------------------------------
How about putting those flags in src/logging/flags.hpp. Looks like it already
provides a set of common flags that is inherited by master, slave, tests, etc.
> Allow for flags that are used on master+slave (+tests)
> ------------------------------------------------------
>
> Key: MESOS-1997
> URL: https://issues.apache.org/jira/browse/MESOS-1997
> Project: Mesos
> Issue Type: Improvement
> Reporter: Till Toenshoff
> Priority: Minor
>
> I am honestly unsure if I was overcomplicating a one-off, simple issue but
> notes like the following make me think about solutions :
> {noformat}
> // This help message for --modules flag is the same for
> // {master,slave,tests}/flags.hpp and should always be kept in
> // sync.
> {noformat}
> So we are starting to introduce flags that are used/usable for multiple
> runnables (e.g. master+slave+tests). These flags are defined separately for
> all those runnables (master/flags.hpp, slave/flags.hpp and tests/flags.hpp).
> As changes for those flags will have to be kept in sync manually, I thought
> we might want to consider introducing flags that cover all runnables instead
> and let the above flags definitions derive from those.
> On the other hand, those would introduce more complexity, given that we
> possibly have various combinatoric scenarios:
> - master+tests
> - slave+tests
> - master+slave
> - master+slave+tests
> Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
