[
https://issues.apache.org/jira/browse/MESOS-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223220#comment-14223220
]
Cody Maloney commented on MESOS-2016:
-------------------------------------
I think you need a combination of "we know this came from mesos" as well as the
particular slave that the container came from (When we are running mesos on
mesos in docker and do fail one of the mesos on mesos nodes it needs to not
clean out other running containers including itself).
Is there any sort of runtime tag that can be applied to docker containers?
Something where we could generate a UUID and say "All mesos launched slaves are
tagged with this UUID". And then on top of that tag with slave id, and task id
to uniquely identify a running task on a slave for easy, predictable recovery.
>From a management perspective we can also get a list from the docker running
>containers of the slaveIDs which are running, and do periodic large cleanups
>to make sure there isn't too much lingering.
> docker_name_prefix is too generic
> ---------------------------------
>
> Key: MESOS-2016
> URL: https://issues.apache.org/jira/browse/MESOS-2016
> Project: Mesos
> Issue Type: Bug
> Reporter: Jay Buffington
> Assignee: Timothy Chen
>
> From docker.hpp and docker.cpp:
> {quote}
> // Prefix used to name Docker containers in order to distinguish those
> // created by Mesos from those created manually.
> extern std::string DOCKER_NAME_PREFIX;
> // TODO(benh): At some point to run multiple slaves we'll need to make
> // the Docker container name creation include the slave ID.
> string DOCKER_NAME_PREFIX = "mesos-";
> {quote}
> This name is too generic. A common pattern in docker land is to run
> everything in a container and use volume mounts to share sockets do RPC
> between containers. CoreOS has popularized this technique.
> Inevitably, what people do is start a container named "mesos-slave" which
> runs the docker containerizer recovery code which removes all containers that
> start with "mesos-" And then ask "huh, why did my mesos-slave docker
> container die? I don't see any error messages..."
> Ideally, we should do what Ben suggested and add the slave id to the name
> prefix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
