[ 
https://issues.apache.org/jira/browse/MESOS-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294600#comment-14294600
 ] 

Benjamin Mahler commented on MESOS-2241:
----------------------------------------

Just ran into this as well, you may want to update the tests so it prints:

{code}
diff --git a/src/tests/disk_quota_tests.cpp b/src/tests/disk_quota_tests.cpp
index 83a9844..20c7c89 100644
--- a/src/tests/disk_quota_tests.cpp
+++ b/src/tests/disk_quota_tests.cpp
@@ -133,12 +133,14 @@ TEST_F(DiskUsageCollectorTest, SymbolicLink)
   Future<Bytes> usage1 = collector.usage(os::getcwd());
   Future<Bytes> usage2 = collector.usage(link);

+  // NOTE: We wrap with Bytes because gtest doesn't know how to print
+  // 'Kilobytes' (even though there is a << operator for Bytes).
   AWAIT_READY(usage1);
-  EXPECT_GE(usage1.get(), Kilobytes(8));
-  EXPECT_LT(usage1.get(), Kilobytes(16));
+  EXPECT_GE(usage1.get(), Bytes(Kilobytes(8)));
+  EXPECT_LT(usage1.get(), Bytes(Kilobytes(16)));

   AWAIT_READY(usage2);
-  EXPECT_LT(usage2.get(), Kilobytes(8));
+  EXPECT_LT(usage2.get(), Bytes(Kilobytes(8)));
 }
{code}

This yields a more helpful output:

{noformat}
[ RUN      ] DiskUsageCollectorTest.SymbolicLink
Using temporary directory '/tmp/DiskUsageCollectorTest_SymbolicLink_RdZa4S'
../../src/tests/disk_quota_tests.cpp:138: Failure
Expected: (usage1.get()) < (Bytes(Kilobytes(16))), actual: 24KB vs 16KB
[  FAILED  ] DiskUsageCollectorTest.SymbolicLink (161 ms)
{noformat}

> DiskUsageCollectorTest.SymbolicLink test is flaky
> -------------------------------------------------
>
>                 Key: MESOS-2241
>                 URL: https://issues.apache.org/jira/browse/MESOS-2241
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Vinod Kone
>            Assignee: Jie Yu
>
> Observed this on a local machine running linux w/ sudo.
> {code}
> [ RUN      ] DiskUsageCollectorTest.SymbolicLink
> ../../src/tests/disk_quota_tests.cpp:138: Failure
> Expected: (usage1.get()) < (Kilobytes(16)), actual: 24KB vs 8-byte object 
> <00-40 00-00 00-00 00-00>
> [  FAILED  ] DiskUsageCollectorTest.SymbolicLink (201 ms)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to