[ 
https://issues.apache.org/jira/browse/MESOS-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318918#comment-14318918
 ] 

Niklas Quarfot Nielsen commented on MESOS-2213:
-----------------------------------------------

commit b3385f3619b53d83004688984b8f4733eb5c5e12
Author: Alexander Rukletsov <[email protected]>
Date:   Thu Feb 12 11:44:58 2015 -0800

    Extracted MesosAllocator into a separate file.

    Review: https://reviews.apache.org/r/29931

commit 336e4e2e6b1cee966f5b72bc23341c54e4813cc9
Author: Alexander Rukletsov <[email protected]>
Date:   Thu Feb 12 11:44:38 2015 -0800

    Cleaned up includes in allocation sources.

    Review: https://reviews.apache.org/r/29929

commit be6246a11276074dfb60a892a890b80cb7cd37cd
Author: Alexander Rukletsov <[email protected]>
Date:   Thu Feb 12 11:44:16 2015 -0800

    Removed unnecessary lifecycle method from MasterAllocatorTest.

    TestAllocator does not cause GMOCK warnings for unused method calls
    any more. Hence there is no need for stopping allocation explicitly.

    Review: https://reviews.apache.org/r/29927

commit 3093759fb978b9131d05510f7f095203d2a383fc
Author: Alexander Rukletsov <[email protected]>
Date:   Thu Feb 12 11:44:06 2015 -0800

    Moved allocation related sources into a separate directory.

    Review: https://reviews.apache.org/r/29925

commit 2b51582a6f6bd3ae431cc4c16ba098656fbd7ef3
Author: Alexander Rukletsov <[email protected]>
Date:   Thu Feb 12 11:42:05 2015 -0800

    Refactored the allocator interface to support general implementations.

    Introduced a basic Allocator interfaced. This interface does not
    require allocators to be based on libprocess processes. For allocators
    that do implement allocation logic via an internal libprocess process,
    a special wrapper is provided. Allocator users and tests are updated
    to use Allocator type instead of AllocatorProcess.

    Review: https://reviews.apache.org/r/29890

> Custom allocators should implement Allocator instead of AllocatorProcess
> ------------------------------------------------------------------------
>
>                 Key: MESOS-2213
>                 URL: https://issues.apache.org/jira/browse/MESOS-2213
>             Project: Mesos
>          Issue Type: Task
>          Components: allocation
>            Reporter: Alexander Rukletsov
>            Assignee: Alexander Rukletsov
>              Labels: mesosphere
>
> Currently new allocation policies can be added by implementing 
> {{AllocatorProcess}} interface, while {{Allocator}} class is a thin wrapper 
> around it. This architecture may be not very favourable, because it imposes 
> restriction on how allocators should be implemented. Additionally, the 
> current design is not consistent with other pluggable—or potentially 
> pluggable—Mesos components, e.g. {{Isolator}}, {{Authenticator}}.
> As we are moving to modularizing the allocator, this ticket aims to change 
> the way we implement allocation policies and instantiate allocators. 
> Allocator tests and {{MockAllocatorProcess}} will be affected as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to