Lukas Loesche created MESOS-2382:
------------------------------------
Summary: replace unsafe "find | xargs" with "find -exec"
Key: MESOS-2382
URL: https://issues.apache.org/jira/browse/MESOS-2382
Project: Mesos
Issue Type: Bug
Components: build
Affects Versions: 0.20.1
Reporter: Lukas Loesche
The problem exists in
1194:src/Makefile.am
47:src/tests/balloon_framework_test.sh
The current "find | xargs rm -rf" in the Makefile could potentially destroy
data if mesos source was in a folder with a space in the name. E.g. if you for
some reason checkout mesos to "/ mesos" the command in src/Makefile.am would
turn into a rm -rf /
"find | xargs" should be NUL delimited with "find -print0 | xargs -0" for safer
execution or can just be replaced with the find build-in option "find -exec
'{}' \+" which behaves similar to xargs.
There was a second occurrence of this in a test script, though in that case it
would only rmdir empty folders, so is less critical.
I submitted a PR here: https://github.com/apache/mesos/pull/36
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
