[ 
https://issues.apache.org/jira/browse/MESOS-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340367#comment-14340367
 ] 

Dominic Hamon commented on MESOS-2418:
--------------------------------------

no more boost please.

there's also {{std::array<char>}} if it's available on our compiler/platform 
suite as it is more similar to the existing fixed-size buffer usage.

{{std::vector<char>}} has the benefit of working in C++03 compatible compilers.

given we can't reach consensus on any use of {{std::unique_ptr}} i doubt it's a 
good fit here.

> Remove raw pointers from stout/os.hpp
> -------------------------------------
>
>                 Key: MESOS-2418
>                 URL: https://issues.apache.org/jira/browse/MESOS-2418
>             Project: Mesos
>          Issue Type: Improvement
>          Components: stout
>            Reporter: Joerg Schad
>            Priority: Minor
>
> In MESOS-2412 a memory leak was found because of a missing {{delete}}. 
> Forgetting to free memory is a common error while manually managing memory. 
> In order to prevent this issue from happening again, another strategy should 
> be used to handle buffers.
> Among the options there are {{std::vector<char>}}, 
> {{std::unique_ptr<char\[\]>}}, or {{boost::scoped_array<char>}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to