[
https://issues.apache.org/jira/browse/MESOS-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Evelina Dumitrescu updated MESOS-2450:
--------------------------------------
Description: The 0 and 2130706433 values should be replaced by INADDR_ANY
and INADDR_LOOPBACK in network order. Also, instead of the 2130706433
(0x7F000001) value, the check should have been done against 16777343( the
localhost IP address as uint32_t in network byte order ). I tried to print the
values for the IP address in process.cpp and saw that the tests only cover the
0 value. Note that despite the IPv6 equivalents(in6addr_any and
in6addr_loopback), the INADDR_ANY and INADDR_LOOPBACK constants are in host
order. (was: The 0 and 2130706433 values should be replaced by INADDR_ANY and
INADDR_LOOPBACK in network order. Also, instead of the 2130706433 value, the
check should have been done against 16777343( the localhost IP address as
uint32_t in network byte order ). I tried to print the values for the IP
address in process.cpp and saw that the tests only cover the 0 value. Note that
despite the IPv6 equivalents(in6addr_any and in6addr_loopback), the INADDR_ANY
and INADDR_LOOPBACK constants are in host order.)
> Hardcoded constants in libprocess should be replaced by their INADDR_XXX
> equivalents
> ------------------------------------------------------------------------------------
>
> Key: MESOS-2450
> URL: https://issues.apache.org/jira/browse/MESOS-2450
> Project: Mesos
> Issue Type: Bug
> Reporter: Evelina Dumitrescu
>
> The 0 and 2130706433 values should be replaced by INADDR_ANY and
> INADDR_LOOPBACK in network order. Also, instead of the 2130706433
> (0x7F000001) value, the check should have been done against 16777343( the
> localhost IP address as uint32_t in network byte order ). I tried to print
> the values for the IP address in process.cpp and saw that the tests only
> cover the 0 value. Note that despite the IPv6 equivalents(in6addr_any and
> in6addr_loopback), the INADDR_ANY and INADDR_LOOPBACK constants are in host
> order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
