[ 
https://issues.apache.org/jira/browse/MESOS-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353464#comment-14353464
 ] 

Dominic Hamon commented on MESOS-1023:
--------------------------------------

commit f780f67717fe0aa25b6870baedd55c43a7017edb (HEAD, origin/master, 
origin/HEAD, master)
Author: Dominic Hamon <[email protected]>
Commit: Dominic Hamon <[email protected]>

    Remove static strings from process and split out some source.
    
    Review: https://reviews.apache.org/r/30841


> Replace all static/global variables with non-POD type
> -----------------------------------------------------
>
>                 Key: MESOS-1023
>                 URL: https://issues.apache.org/jira/browse/MESOS-1023
>             Project: Mesos
>          Issue Type: Bug
>          Components: general, technical debt
>            Reporter: Dominic Hamon
>            Assignee: Dominic Hamon
>              Labels: c++
>
> See 
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Static_and_Global_Variables
>  for the background.
> Real bugs have been seen. For example, in process::ID::generate we have a 
> map<string, int> that can be accessed within the function after exit has been 
> called. Ie, we can try to access the map after it's been destroyed, but 
> before exit has completed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to