[ https://issues.apache.org/jira/browse/MESOS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387802#comment-14387802 ]
Benjamin Hindman commented on MESOS-2564: ----------------------------------------- The intention was to force people to capture all of their forward declarations at the top of the file, and by explicitly calling them out with a comment it made it more "clear" that is where they belong (where as it's already common convention to always put your includes at the beginning of the file, although not necessary). I don't really see a ton of value of removing these, I don't see how/why they are negatively impacting the code base? > Kill superfluous forward declaration comments. > ---------------------------------------------- > > Key: MESOS-2564 > URL: https://issues.apache.org/jira/browse/MESOS-2564 > Project: Mesos > Issue Type: Improvement > Reporter: Alexander Rukletsov > Priority: Minor > Labels: easyfix, newbie > > We often prepend forward declarations with a comment, which is pretty > useless, e.g.: > {code} > // Forward declarations. > class LogStorageProcess; > {code} > or > {code} > // Forward declarations. > namespace registry { > class Slaves; > } > class Authorizer; > class WhitelistWatcher; > {code} > This JIRA aims to clean up such comments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)