[
https://issues.apache.org/jira/browse/MESOS-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390974#comment-14390974
]
haosdent edited comment on MESOS-2576 at 4/2/15 3:06 AM:
---------------------------------------------------------
Hi, [~tillt] [~nnielsen]. I upload a sample
[MESOS-2576_sample.diff|https://issues.apache.org/jira/secure/attachment/12708735/MESOS-2576_sample.diff]
. Could you help me check if this follow the style guide? Thank you.
was (Author: [email protected]):
Hi, [~tillt] [~nnielsen]. I upload a sample MESOS-2576_sample.diff . Could you
help me check if this follow the style guide? Thank you.
> Camel-case libprocess variable and method names
> -----------------------------------------------
>
> Key: MESOS-2576
> URL: https://issues.apache.org/jira/browse/MESOS-2576
> Project: Mesos
> Issue Type: Improvement
> Components: technical debt
> Reporter: Niklas Quarfot Nielsen
> Priority: Trivial
> Attachments: MESOS-2576_sample.diff
>
>
> We should make naming consistent in libprocess and have it follow our style
> guide.
> For example:
> {code}
> void send_connect(
> const Future<Nothing>& future,
> Socket* socket,
> Message* message)
> {
> if (future.isDiscarded() || future.isFailed()) {
> if (future.isFailed()) {
> VLOG(1) << "Failed to send '" << message->name << "' to '"
> << message->to.address << "', connect: " << future.failure();
> }
> socket_manager->close(*socket);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
