[
https://issues.apache.org/jira/browse/MESOS-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482495#comment-14482495
]
Joris Van Remoortere commented on MESOS-2576:
---------------------------------------------
[[email protected]] Although the project currently uses camel case, there are
some arguments and movement for snake case. Considering this I'm not sure that
this ticket is the best to work on.
In the Mesos community we try to find a shepherd for and make sure that a JIRA
ticket is 'Accepted' (as opposed to 'Open') before work is done on it so as to
avoid this scenario. I will work with the team to try and make sure this
procedure is more well documented. This extra transition of a ticket into
'Accepted' helps to verify that this is something we truly want to work on.
Maybe you can reach out via the mailing list or the IRC and work with one of
the committers to find an 'Accepted' ticket, or move one into 'Accepted' before
working on it.
Thanks for your effort, and I look forward to seeing more patches from you!
> Camel-case libprocess variable and method names
> -----------------------------------------------
>
> Key: MESOS-2576
> URL: https://issues.apache.org/jira/browse/MESOS-2576
> Project: Mesos
> Issue Type: Improvement
> Components: technical debt
> Reporter: Niklas Quarfot Nielsen
> Priority: Trivial
> Attachments: MESOS-2576_sample.diff
>
>
> We should make naming consistent in libprocess and have it follow our style
> guide.
> For example:
> {code}
> void send_connect(
> const Future<Nothing>& future,
> Socket* socket,
> Message* message)
> {
> if (future.isDiscarded() || future.isFailed()) {
> if (future.isFailed()) {
> VLOG(1) << "Failed to send '" << message->name << "' to '"
> << message->to.address << "', connect: " << future.failure();
> }
> socket_manager->close(*socket);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
