[ 
https://issues.apache.org/jira/browse/MESOS-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326795#comment-14326795
 ] 

Adam B edited comment on MESOS-2351 at 4/11/15 10:36 AM:
---------------------------------------------------------

Relevant reviews (in order):
https://reviews.apache.org/r/30961/
https://reviews.apache.org/r/30962/
https://reviews.apache.org/r/31016/
https://reviews.apache.org/r/31028/
https://reviews.apache.org/r/32948/
https://reviews.apache.org/r/31017/

Discarded:
https://reviews.apache.org/r/31027/


was (Author: adam-mesos):
Relevant reviews (in order):
https://reviews.apache.org/r/30961/
https://reviews.apache.org/r/30962/
https://reviews.apache.org/r/31027/
https://reviews.apache.org/r/31016/
https://reviews.apache.org/r/31028/
https://reviews.apache.org/r/31017/

> Enable label and environment decorators (hooks) to remove label and 
> environment entries
> ---------------------------------------------------------------------------------------
>
>                 Key: MESOS-2351
>                 URL: https://issues.apache.org/jira/browse/MESOS-2351
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Niklas Quarfot Nielsen
>            Assignee: Niklas Quarfot Nielsen
>
> We need to change the semantics of decorators to be able to not only add 
> labels and environment variables, but also remove them.
> The change is fairly small. The hook manager (and call site) use CopyFrom 
> instead of MergeFrom and hook implementors pass on the labels and environment 
> from task and executor commands respectively.
> In the future, we can tag labels such that only labels belonging to a hook 
> type (across master and slave) can be inspected and changed. For now, the 
> active hooks are selected by the operator and therefore be trusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to